How do we review the code nobody understands?
https://github.com/openssl/openssl/pull/28990 is an example of such PR. It's huge, it requires specific ASM knowledge, and the only thing that can be done by me is a check that the tests pass on the relevant platform (they do).
As the patch closes a real-world issue, I think it needs to be dealt with, we can't just ignore it. So what is the way forward in this case?
Paul Yang Sun 16 Nov 2025 1:25AM
@Neil Horman Absolutely, this way is a very effective collaboration method of a 'community' for involving more people in
Todd Short Thu 30 Oct 2025 4:49PM
Has AI review been considered (i.e. copilot in GitHub)?
Paul Yang Sat 15 Nov 2025 3:42PM
@Todd Short I highly agree with this
Neil Horman Sat 15 Nov 2025 8:12PM
@Paul Yang I'm not opposed to adding copilot or codeQL or some such to our review process, but I would personally have to see some effective reviews from an AI before I placed anything close to the same trust that I would place in a maintainers file set of people to it.
Shane Lontis Thu 6 Nov 2025 12:55AM
I wasnt suggesting that OpenSSL resources need to know 'everything', it could be divided per platform for example.
Shane Lontis Sun 9 Nov 2025 11:32PM
I would suggest that if we are relying on code coming in from external sources for assembly that we should be a bit more strict when reviewing in terms of asking for more documentation/comments explaining the code and techniques used. A fair proportion of the contributors in this space seem to disappear over time.
Kurt Roeckx Wed 12 Nov 2025 7:24AM
It's possible to formally prove various things about the assembler. This will require a large effort at the start. But the result is going to be that we have a higher trust that the code does the right thing in corner cases.
Neil Horman · Sat 15 Nov 2025 8:10PM
@Paul Yang yes, I agree, we seem to be doing this somewhat organically (if not consistently) already. I'd just be looking for a level of formalization, if for no other reason than to give new people the project a way to find/identify who those codeowners/maintainers are. In so far as approvals counting goes, that probably needs some discussion as to the actual mechanism (i.e. we would need some tooling changes so that people in code owners could be treated like comitters for the purposes of approval without giving them write access to the tree), but in general, I agree with the approach.